fix(metrics): don't collect internal Telegraf metrics #3193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm-sumo
force-pushed
the
fix/metrics/telegraf-internal-metrics
branch
from
9f6d502
to
df7f66f
Compare
kkujawa-sumo
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, Telegraf operator adds an
internalinput which collects Telegraf's own metrics. In addition, the Prometheus output exposes process and gocollector metrics. We don't want either of these enabled by default.Unfortunately this behaviour of Telegraf operator can only be disabled via a flag passed on the command line, and the Helm Chart doesn't allow changing these. So instead we drop the metrics in the output.
Checklist