Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: use zstd compression for internal otlp data" #3197

Merged
merged 1 commit into from Aug 10, 2023

Conversation

swiatekm-sumo
Copy link
Contributor

@swiatekm-sumo swiatekm-sumo commented Aug 10, 2023

This reverts commit c185803. See: open-telemetry/opentelemetry-collector#8216.

I'm going to backport this fix to 3.12 and 3.11, as it's quite disruptive.

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

@github-actions github-actions bot added the documentation documentation label Aug 10, 2023
@swiatekm-sumo swiatekm-sumo marked this pull request as ready for review August 10, 2023 11:30
@swiatekm-sumo swiatekm-sumo requested a review from a team as a code owner August 10, 2023 11:30
Copy link
Collaborator

@aboguszewski-sumo aboguszewski-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be all occurences. Don't we want to use other compression for the time being?

@swiatekm-sumo
Copy link
Contributor Author

Seems to be all occurences. Don't we want to use other compression for the time being?

OTLP exporter uses gzip by default.

@swiatekm-sumo swiatekm-sumo merged commit 1461346 into main Aug 10, 2023
47 checks passed
@swiatekm-sumo swiatekm-sumo deleted the fix/zstd-compression branch August 10, 2023 11:49
@sumo-backporter
Copy link
Contributor

The backport to release-v3.11 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-v3.11 release-v3.11
# Navigate to the new working tree
cd .worktrees/backport-release-v3.11
# Create a new branch
git switch --create backport-3197-to-release-v3.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1461346704acb8a296b5cfaff13ee0ee614fbc1a
# Push it to GitHub
git push --set-upstream origin backport-3197-to-release-v3.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-v3.11

Then, create a pull request where the base branch is release-v3.11 and the compare/head branch is backport-3197-to-release-v3.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants