feat(metrics/collector): support remote write proxy #3221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm-sumo
force-pushed
the
feat/metrics-collector/remote-write-proxy
branch
2 times, most recently
from
281c358
to
817fe7e
Compare
swiatekm-sumo
force-pushed
the
feat/metrics-collector/remote-write-proxy
branch
from
817fe7e
to
1e2f899
Compare
This is based on internal dogfooding. The collector is, in general, is heavily memory-bound, much like Prometheus.
swiatekm-sumo
force-pushed
the
feat/metrics-collector/remote-write-proxy
branch
from
1e2f899
to
70843e2
Compare
swiatekm-sumo
commented
Aug 21, 2023
| @@ -364,6 +364,7 @@ var ( | |||
| "otelcol_otelsvc_k8s_ip_lookup_miss", | |||
| "otelcol_otelsvc_k8s_other_deleted", | |||
| "kube_pod_container_status_waiting_reason", | |||
| "kube_pod_container_status_terminated_reason", | |||
There was a problem hiding this comment.
This is just another flaky metric I found while testing this change.
sumo-drosiek
approved these changes
Aug 21, 2023
In that case I think it's better to wait for the upstream setting. Remote write proxy is already here, so using it is very little additional effort. This is also a much smaller problem for logs, where we have a lot more collectors than metadata Pods. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remote write proxy was originally disabled for the otel metrics collector. Until we've added the ability to disable persistent connections in the upstream collector, it's still useful for load balancing.
Checklist