Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metrics/collector): allow setting allocation strategy #3226

Merged
merged 1 commit into from
Aug 21, 2023
Merged

feat(metrics/collector): allow setting allocation strategy #3226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/3226.added.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
feat(metrics/collector): allow setting allocation strategy
1 change: 1 addition & 0 deletions deploy/helm/sumologic/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ The following table lists the configurable parameters of the Sumo Logic chart an
| `sumologic.metrics.collector.otelcol.kubelet.enabled` | Enable collection of kubelet metrics. | `true` |
| `sumologic.metrics.collector.otelcol.cAdvisor.enabled` | Enable collection of cAdvisor metrics. | `true` |
| `sumologic.metrics.collector.otelcol.annotatedPods.enabled` | Enable collection of metrics from Pods annotated with prometheus.io/\* keys. See [docs/collecting-application-metrics.md](/docs/collecting-application-metrics.md#application-metrics-are-exposed-one-endpoint-scenario) for more information. | `true` |
| `sumologic.metrics.collector.otelcol.allocationStrategy` | Allocation strategy for the scrape target allocator. Valid values are: least-weighted and consistent-hashing. See: https://github.com/open-telemetry/opentelemetry-operator/blob/main/docs/api.md#opentelemetrycollectorspectargetallocator | `least-weighted` |
| `sumologic.metrics.dropHistogramBuckets` | Drop buckets from select high-cardinality histogram metrics, leaving only the sum and count components. | `true` |
| `sumologic.traces.enabled` | Set the enabled flag to true to enable tracing ingestion. _Tracing must be enabled for the account first. Please contact your Sumo representative for activation details_ | `true` |
| `sumologic.traces.spans_per_request` | Maximum number of spans sent in single batch | `100` |
Expand Down
3 changes: 3 additions & 0 deletions deploy/helm/sumologic/templates/metrics/collector/otelcol/opentelemetrycollector.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ spec:
replicas: {{ .Values.sumologic.metrics.collector.otelcol.replicaCount }}
serviceAccount: {{ template "sumologic.metadata.name.metrics.collector.serviceaccount" . }}
targetAllocator:
{{- if .Values.sumologic.metrics.collector.otelcol.allocationStrategy }}
allocationStrategy: {{ .Values.sumologic.metrics.collector.otelcol.allocationStrategy }}
{{- end }}
serviceAccount: {{ template "sumologic.metadata.name.metrics.targetallocator.serviceaccount" . }}
enabled: true
filterStrategy: relabel-config
Expand Down
4 changes: 4 additions & 0 deletions deploy/helm/sumologic/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,6 +524,10 @@ sumologic:
annotatedPods:
enabled: true

## Allocation strategy for the scrape target allocator. Valid values are: least-weighted and consistent-hashing.
## See: https://github.com/open-telemetry/opentelemetry-operator/blob/main/docs/api.md#opentelemetrycollectorspectargetallocator
# allocationStrategy: least-weighted

## Default metric filters for Sumo Apps
enableDefaultFilters: false

Expand Down
1 change: 1 addition & 0 deletions tests/helm/testdata/goldenfile/metrics_collector_otc/custom.input.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ sumologic:
enabled: false
annotatedPods:
enabled: false
allocationStrategy: consistent-hashing
enableDefaultFilters: true
dropHistogramBuckets: false

Expand Down
1 change: 1 addition & 0 deletions tests/helm/testdata/goldenfile/metrics_collector_otc/custom.output.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ spec:
replicas: 1
serviceAccount: RELEASE-NAME-sumologic-metrics
targetAllocator:
allocationStrategy: consistent-hashing
serviceAccount: RELEASE-NAME-sumologic-metrics-targetallocator
enabled: true
filterStrategy: relabel-config
Expand Down