Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fluent-bit): set Time_Keep to On in containerd parser #3227

Merged
merged 1 commit into from Sep 6, 2023
Merged

fix(fluent-bit): set Time_Keep to On in containerd parser #3227

merged 1 commit into from Sep 6, 2023

Conversation

aboguszewski-sumo
Copy link
Collaborator

Ref: fluent/fluent-bit#3087

A customer reported this. Without setting this, the time attribute is empty.

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

@aboguszewski-sumo aboguszewski-sumo requested a review from a team as a code owner August 21, 2023 13:28
github-actions[bot]
github-actions bot requested changes Aug 21, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains invalid labels. Please remove all of the following labels: ['do-not-merge/hold']

swiatekm-sumo
swiatekm-sumo approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@swiatekm-sumo swiatekm-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully verified this change, we can merge it before branching off v4.

@aboguszewski-sumo aboguszewski-sumo merged commit 5b27dd1 into main Sep 6, 2023
45 checks passed
@aboguszewski-sumo aboguszewski-sumo deleted the ab-fix-keep-time branch September 6, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions approved these changes

@swiatekm-sumo swiatekm-sumo swiatekm-sumo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aboguszewski-sumo @swiatekm-sumo