Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include buffer.output.conf for events configmap #327

Merged
merged 2 commits into from
Dec 2, 2019
Merged

Include buffer.output.conf for events configmap #327

merged 2 commits into from
Dec 2, 2019

Conversation

vsinghal13
Copy link
Contributor

@vsinghal13 vsinghal13 commented Dec 2, 2019 •
edited
Loading

Description

Include buffer.output.conf for events configmap

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

samjsong
samjsong approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into it and fixing Vijit!

@vsinghal13 vsinghal13 merged commit 85e36fe into master Dec 2, 2019
@vsinghal13 vsinghal13 deleted the vsinghal-fix-file-buffer-config branch December 2, 2019 23:47
@vsinghal13 vsinghal13 mentioned this pull request Dec 2, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samjsong samjsong samjsong approved these changes

@rvmiller89 rvmiller89 Awaiting requested review from rvmiller89

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vsinghal13 @samjsong