Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ambiguity in helm install command #336

Merged
merged 2 commits into from
Dec 12, 2019
Merged

Fix ambiguity in helm install command #336

merged 2 commits into from
Dec 12, 2019

Conversation

samjsong
Copy link
Contributor

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@rvmiller89
Copy link
Contributor

What's the issue with the quotes?

vsinghal13
vsinghal13 reviewed Dec 12, 2019
View reviewed changes
Copy link
Contributor

@vsinghal13 vsinghal13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just for consistency of using CAPS letters or the quotes have any effect?

@samjsong
Copy link
Contributor Author

Synced offline, there should be nothing wrong with the quotes and in fact they are necessary if there is a space in the cluster/collector name.

@samjsong samjsong merged commit 2a922cf into master Dec 12, 2019
@samjsong samjsong deleted the samjsong-patch-1 branch December 12, 2019 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsinghal13 vsinghal13 vsinghal13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samjsong @rvmiller89 @vsinghal13