Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instrumentation): replace tools image with kubectl #3373

Merged
merged 1 commit into from Nov 3, 2023

Conversation

swiatekm-sumo
Copy link
Contributor

The kubernetes-tools image isn't supported for production use. The kubectl image with minimal dependencies suffices for applying default instrumentation CRs.

Checklist

  • Changelog updated or skip changelog label added

The kubernetes-tools image isn't supported for production use. The
kubectl image with minimal dependencies suffices for applying default
instrumentation CRs.
@swiatekm-sumo swiatekm-sumo requested a review from a team as a code owner November 2, 2023 18:02
@github-actions github-actions bot added the documentation documentation label Nov 2, 2023
Copy link
Contributor

@mat-rumian mat-rumian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@swiatekm-sumo swiatekm-sumo merged commit d20f080 into main Nov 3, 2023
36 checks passed
@swiatekm-sumo swiatekm-sumo deleted the fix/replace-tools branch November 3, 2023 09:50
@sumo-backporter
Copy link
Contributor

The backport to release-v3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-v3 release-v3
# Navigate to the new working tree
cd .worktrees/backport-release-v3
# Create a new branch
git switch --create backport-3373-to-release-v3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d20f0801ea3ede62cc463e4432750f3ab5786484
# Push it to GitHub
git push --set-upstream origin backport-3373-to-release-v3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-v3

Then, create a pull request where the base branch is release-v3 and the compare/head branch is backport-3373-to-release-v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants