Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new service account for the otel cloudwatch collector statefulset #3374

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Add new service account for the otel cloudwatch collector statefulset #3374

merged 1 commit into from
Nov 3, 2023

Conversation

rnishtala-sumo
Copy link
Contributor

@rnishtala-sumo rnishtala-sumo commented Nov 2, 2023 •
edited
Loading

Add new service account for the otel cloudwatch collector statefulset

E2E test: https://ct-jenkins.kumoroku.com/view/All%20Dev%20Jobs/job/dev-sumo-platform-test-k8s-collection/2085/console

Checklist

  • Changelog updated or skip changelog label added
  • Template tests added for new features
  • E2E tests

ccressent
ccressent approved these changes Nov 2, 2023
View reviewed changes
Copy link

@ccressent ccressent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me at a high level, though I have to admit my Helm knowledge is limited and I did not test it.

@rnishtala-sumo rnishtala-sumo marked this pull request as ready for review November 2, 2023 21:09
@rnishtala-sumo rnishtala-sumo requested a review from a team as a code owner November 2, 2023 21:09
@rnishtala-sumo rnishtala-sumo merged commit 0ca279c into main Nov 3, 2023
58 checks passed
@rnishtala-sumo rnishtala-sumo deleted the cw-svc-account branch November 3, 2023 13:45
sumo-backporter bot pushed a commit that referenced this pull request Nov 3, 2023
@rnishtala-sumo @github-actions
Add new service account for the otel cloudwatch collector statefulset (…
3638091 
…#3374)

(cherry picked from commit 0ca279c)
@sumo-backporter sumo-backporter bot mentioned this pull request Nov 3, 2023
Merged
rnishtala-sumo added a commit that referenced this pull request Nov 3, 2023
@sumo-backporter @rnishtala-sumo
Add new service account for the otel cloudwatch collector statefulset (…
f36a8da 
…#3374) (#3380)

(cherry picked from commit 0ca279c)

Co-authored-by: Raj Nishtala <113392743+rnishtala-sumo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccressent ccressent ccressent approved these changes

@github-actions github-actions[bot] github-actions approved these changes

@swiatekm-sumo swiatekm-sumo swiatekm-sumo approved these changes

Assignees
No one assigned
Labels
backport release-v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnishtala-sumo @ccressent @swiatekm-sumo