fix(metrics): use targetallocator serviceaccount created by the operator #3447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sumo-drosiek
approved these changes
Dec 14, 2023
swiatekm-sumo
force-pushed
the
fix/metrics/targetallocator-serviceaccount
branch
from
cda1301
to
212b872
Compare
swiatekm-sumo
force-pushed
the
fix/metrics/targetallocator-serviceaccount
branch
from
212b872
to
5638067
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's currently a bug in otel operator (open-telemetry/opentelemetry-operator#2443) which causes it to create a ServiceAccount for the Target Allocator even if we provide our own. In practice, we used the same name as the operator, so it only changed some labels. As a work around for this bug, we just let the operator handle this.
Checklist