Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix capabilities check for PodDisrutionBudget #3514

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

sharkannon
Copy link
Contributor

@sharkannon sharkannon commented Jan 23, 2024

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

…tionBudget is not a part of .Capabilities.APIVersions however policy/v1 is
@sharkannon sharkannon changed the title 3513 Issue #3513 updating policy check for PDB's Jan 23, 2024
@sharkannon sharkannon changed the title Issue #3513 updating policy check for PDB's fix: Issue #3513 updating policy check for PDB's Jan 23, 2024
@sharkannon
Copy link
Contributor Author

Example of what I mean based on the value of Capabilities.APIVersions

Helm Template:

{{- range $key := $.Capabilities.APIVersions }}
- {{ . }}
{{- end }} 

Output:

- v1
- admissionregistration.k8s.io/v1
- admissionregistration.k8s.io/v1alpha1
- admissionregistration.k8s.io/v1beta1
- internal.apiserver.k8s.io/v1alpha1
- apps/v1
- apps/v1beta1
- apps/v1beta2
- authentication.k8s.io/v1
- authentication.k8s.io/v1alpha1
- authentication.k8s.io/v1beta1
- authorization.k8s.io/v1
- authorization.k8s.io/v1beta1
- autoscaling/v1
- autoscaling/v2
- autoscaling/v2beta1
- autoscaling/v2beta2
- batch/v1
- batch/v1beta1
- certificates.k8s.io/v1
- certificates.k8s.io/v1beta1
- certificates.k8s.io/v1alpha1
- coordination.k8s.io/v1beta1
- coordination.k8s.io/v1
- discovery.k8s.io/v1
- discovery.k8s.io/v1beta1
- events.k8s.io/v1
- events.k8s.io/v1beta1
- extensions/v1beta1
- flowcontrol.apiserver.k8s.io/v1
- flowcontrol.apiserver.k8s.io/v1beta1
- flowcontrol.apiserver.k8s.io/v1beta2
- flowcontrol.apiserver.k8s.io/v1beta3
- networking.k8s.io/v1
- networking.k8s.io/v1alpha1
- networking.k8s.io/v1beta1
- node.k8s.io/v1
- node.k8s.io/v1alpha1
- node.k8s.io/v1beta1
- policy/v1
- policy/v1beta1
- rbac.authorization.k8s.io/v1
- rbac.authorization.k8s.io/v1beta1
- rbac.authorization.k8s.io/v1alpha1
- resource.k8s.io/v1alpha2
- scheduling.k8s.io/v1alpha1
- scheduling.k8s.io/v1beta1
- scheduling.k8s.io/v1
- storage.k8s.io/v1beta1
- storage.k8s.io/v1
- storage.k8s.io/v1alpha1
- apiextensions.k8s.io/v1beta1
- apiextensions.k8s.io/v1

Note, policy/v1/PodDisruptionBudget doesn't exist, so the original check would always show "false"

@sumo-drosiek sumo-drosiek changed the title fix: Issue #3513 updating policy check for PDB's fix: fix policy check for PDB's Jan 29, 2024
@sumo-drosiek sumo-drosiek changed the title fix: fix policy check for PDB's fix: fix capabilities check for PodDisrutionBudget Jan 29, 2024
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please update changelog entry

@sharkannon
Copy link
Contributor Author

@sumo-drosiek Just updated the changelog to match what you requested.

@sumo-drosiek sumo-drosiek enabled auto-merge (squash) January 29, 2024 21:09
@sumo-drosiek sumo-drosiek merged commit 14fc26c into SumoLogic:main Jan 29, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants