Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tracesgateway): move config map from values.yaml #3525

Merged
merged 15 commits into from Feb 9, 2024
Merged

feat(tracesgateway): move config map from values.yaml #3525

merged 15 commits into from Feb 9, 2024

Conversation

mat-rumian
Copy link
Contributor

@mat-rumian mat-rumian commented Feb 5, 2024 •
edited

PR moves traces-gateway configuration from values.yaml file to it's own confmap.

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

@mat-rumian mat-rumian requested a review from a team as a code owner February 5, 2024 11:32
github-actions[bot]
github-actions bot requested changes Feb 5, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains invalid labels. Please remove all of the following labels: ['do-not-merge/hold']

mat-rumian and others added 2 commits February 8, 2024 11:30
@mat-rumian @sumo-drosiek
Update deploy/helm/sumologic/templates/_helpers/_traces.tpl
0e4cae0 
Co-authored-by: Dominik Rosiek <58699848+sumo-drosiek@users.noreply.github.com>
@mat-rumian
Merge branch 'main' into mat-rumian-migrate-instr-cfg
142ecdc
@mat-rumian @sumo-drosiek
Update deploy/helm/sumologic/README.md
e644866 
Co-authored-by: Dominik Rosiek <58699848+sumo-drosiek@users.noreply.github.com>
@mat-rumian mat-rumian enabled auto-merge (squash) February 9, 2024 11:17
@mat-rumian mat-rumian merged commit e673935 into main Feb 9, 2024
37 checks passed
@mat-rumian mat-rumian deleted the mat-rumian-migrate-instr-cfg branch February 9, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions approved these changes

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mat-rumian @sumo-drosiek