feat(metrics): allow customizing kubelet metrics #3528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Maybe would it be nicer to have list of regexes and conacatenate them with |
That might be more readable, but a single regex is more explicit. And you can just copy paste a custom regex from your ServiceMonitor config and have it work here. |
swiatekm-sumo
force-pushed
the
feat/kubelet-metric-regex
branch
from
c0713bd
to
a0f04a2
Compare
swiatekm-sumo
force-pushed
the
feat/kubelet-metric-regex
branch
from
a0f04a2
to
d1cafaa
Compare
sumo-drosiek
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Otel for metrics, we don't use ServiceMonitors for kubelet and cAdvisor metrics. The Service for this is maintained by prometheus-operator, which we don't have available, so we use a manual scrape config instead. This change allows the metric regex for this scrape config to be modified, letting users customize what they want to collect.
This should resolve #3500.
Checklist