Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[breaking change] Add pre-upgrade hook for setup" #357

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Revert "[breaking change] Add pre-upgrade hook for setup" #357

merged 1 commit into from
Jan 9, 2020

Conversation

maimaisie
Copy link
Contributor

Reverts #335

Need to revert since we want to make a minor release

samjsong
samjsong approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry you've had to revert this PR so many times :(

@maimaisie maimaisie merged commit c59edc4 into master Jan 9, 2020
@maimaisie maimaisie deleted the revert-335-maisie-pre-upgrade-revert branch January 9, 2020 21:13
@maimaisie maimaisie mentioned this pull request Feb 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samjsong samjsong samjsong approved these changes

@vsinghal13 vsinghal13 vsinghal13 approved these changes

@rvmiller89 rvmiller89 Awaiting requested review from rvmiller89

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maimaisie @samjsong @vsinghal13