disable metrics-server dependency by default #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samjsong
approved these changes
Jan 9, 2020
|
Should we include the documentation changes as part of this PR as well? |
rvmiller89
approved these changes
Jan 9, 2020
maimaisie
approved these changes
Jan 9, 2020
Actually there is an existing documentation PR #329 , which is as per the breaking change, so I did not include it now. Was planning to add this there itself. |
|
Hmm, that PR does not include any docs for autoscaling and metrics server, correct? |
|
Yes, that PR does not include this as of now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR disabled the
metrics-serverhelm chart dependency by default.metrics-serveris only required for thefluentdHPA , which is disabled by default, so we are also defaulting this dependency tofalse.It is primarily done to cover the scenario, where the user already has
metrics-serverinstalled in the k8s cluster, then our helm install command would fail with the error :Error: release collection failed: apiservices.apiregistration.k8s.io "v1beta1.metrics.k8s.io" already existsNow, if the user wants to enable autoscaling for fluentd they will have to do the following steps:
metrics-serverdependencyNote: if
metrics-serveris already installed , this step is not required2.Enable autoscaling for fluentd
Testing performed
helm installcommand and verified that helm install and upgrade are successful