fix(metrics): change targetallocator ServiceAccount name #3604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid conflict with the operator's default. After the change, we can freely switch between the two without worrying about ownership conflicts. Helm errors if we tell it to manage a resource which already exists and is managed by the operator.
In #3515 we let the operator manage the target allocator's ServiceAccount. Then in #3539, we went back to managing it ourselves, because we needed to attach our own pull secrets to it. This results in an error when upgrading, because Helm refuses to manage a resource which is already managed by the operator, based on standard labels. Changing the name fixes this problem.
Fixes #3588. I'm also going to backport this change to v4.5 and release v4.5.2, as it currently blocks the upgrade for any user with Otel metrics enabled.
Checklist