Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Byi oweners ref #37

Merged
merged 6 commits into from
Jun 11, 2019
Merged

Byi oweners ref #37

merged 6 commits into from
Jun 11, 2019

Conversation

bin3377
Copy link

@bin3377 bin3377 commented Jun 3, 2019 •
edited
Loading

Append names of resources in owner chain to metadata:

  • Fetch owner information in BFS
  • Cache owners' informatin
  • Using multiple kubeclient objects to get resources in different API groups/versions
  • Change in_namespace_path and in_pod_path to array since we need to adaptor both pod_name and pod

FYI - @maimaisie @yuting-liu

@bin3377 bin3377 requested review from samjsong and lei-sumo June 3, 2019 23:36
samjsong
samjsong approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor nit but great stuff, thanks Bin!

fluent-plugin-enhance-k8s-metadata/lib/sumologic/kubernetes/reader.rb Outdated
owner_references(current).each do |owner_reference|
begin
if visited.key?(owner_reference['uid'])
log.debug "#{owner_reference['name']} visted."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: visited

@bin3377 bin3377 merged commit 9edea96 into master Jun 11, 2019
@bin3377 bin3377 deleted the byi-oweners-ref branch June 11, 2019 17:58
psaia pushed a commit to psaia/sumologic-kubernetes-collection that referenced this pull request May 25, 2021
@melmaliacone
Add file with list of roles and member emails (SumoLogic#37)
8e5d283 
* Add file outputted from script. Contains list of roles with their name and a list of member emails

* Remove roles already managed by terraform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samjsong samjsong samjsong approved these changes

@lei-sumo lei-sumo Awaiting requested review from lei-sumo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bin3377 @samjsong