expose cache params for enhance_k8s_metadata plugin #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t cache size to 10000
vsinghal13
requested review from
rvmiller89,
samjsong,
lei-sumo and
frankreno
rvmiller89
reviewed
Jan 29, 2020
…b.com/SumoLogic/sumologic-kubernetes-collection into vsinghal-expose-metadata-cache-params
rvmiller89
reviewed
Jan 29, 2020
samjsong
reviewed
Jan 29, 2020
There was a problem hiding this comment.
I agree that these values should probably be controlled by the same config in the values.yaml file but it's a little confusing that they go under k8sMetadataFilter and reference the 3rd party plugin docs
though I suppose if we want to be minimally intrusive here, we don't have much of a choice but to keep them under k8sMetadataFilter :(
…b.com/SumoLogic/sumologic-kubernetes-collection into vsinghal-expose-metadata-cache-params
rvmiller89
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expose cache params for enhance_k8s_metadata plugin and change default cache size to 10000
Testing performed