Update setup script for logs and events #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maimaisie
approved these changes
Jun 4, 2019
|
Thanks for the catch, let me make the relevant README changes in this PR |
bin3377
reviewed
Jun 5, 2019
deploy/README.md
Outdated
| ``` | ||
|
|
||
| __NOTE__ This script will be executed in bash and requires [jq command-line JSON parser](https://stedolan.github.io/jq/download/) to be installed. | ||
|
|
||
| #### Parameters | ||
|
|
||
| * __-c collector-name__ - optional. Name of Sumo collector that will be created. If not specified, it will be named as `kubernetes-<timestamp>` | ||
| * __-k cluster-name__ - optional. Name of the Kubernetes cluster that will be attached to logs as metadata. If not specified, it will be named as `kubernetes-<timestamp>` |
There was a problem hiding this comment.
so this change only apply to log? (how about metrics/event?)
There was a problem hiding this comment.
cluster name attaches the fields:{cluster:CLUSTER_NAME} to the metadata of the collector, which gets attached to all the logs sent to that collector. Actually since we receive events as logs in Sumo, this should also apply for events. For metrics, you have to set the same CLUSTER_NAME in the prometheus operator overrides.yaml
prometheus:
prometheusSpec:
externalLabels:
# Set this to a value to distinguish between different k8s clusters
cluster: kubernetes
Eventually this value can be enforced the same in the helm chart when we release that.
bin3377
approved these changes
Jun 5, 2019
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
* add ad syncing tool * remove test files * go fmt * update env options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-metricssuffix to metrics sourcessumologicand include all endpoints in this single secretclusterfield to the collector upon creation to keep it consistent with metricsFYI - @ggarg2906sumo @yuting-liu @lei-sumo