Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing double quotes #383

Merged
merged 3 commits into from Jan 31, 2020
Merged

Add missing double quotes #383

merged 3 commits into from Jan 31, 2020

Conversation

maimaisie
Copy link
Contributor

Description

TF complains about missing double quotes in rendered source category for events source.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

vsinghal13
vsinghal13 approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@vsinghal13 vsinghal13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Maisie!

@maimaisie maimaisie merged commit 14297c7 into master Jan 31, 2020
@maimaisie maimaisie deleted the maisie-events-source-category branch January 31, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsinghal13 vsinghal13 vsinghal13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maimaisie @vsinghal13