Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change buffer params #392

Merged
merged 3 commits into from Feb 4, 2020
Merged

change buffer params #392

merged 3 commits into from Feb 4, 2020

Conversation

vsinghal13
Copy link
Contributor

@vsinghal13 vsinghal13 commented Feb 4, 2020 •
edited

Description

This PR adds the new buffer parameter: queued_chunks_limit_size which limits the number of queued chunks. Its default value is the number of threads which is flush_thread_count . This value is set to be 128 so that at max we would have 128 chunks of 1 MB each, in the queue whose size total_limit_size is 128MB.

Also, changing the default chunk size chunk_limit_size to 1MB from 100k.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@vsinghal13 vsinghal13 merged commit e8627ed into master Feb 4, 2020
@vsinghal13 vsinghal13 deleted the vsinghal-change-buffer-params branch February 4, 2020 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maimaisie maimaisie maimaisie approved these changes

@rvmiller89 rvmiller89 rvmiller89 approved these changes

@samjsong samjsong Awaiting requested review from samjsong

@lei-sumo lei-sumo Awaiting requested review from lei-sumo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vsinghal13 @maimaisie @rvmiller89