Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comment out libsonnet stuff #410

Merged
merged 3 commits into from Feb 12, 2020
Merged

comment out libsonnet stuff #410

merged 3 commits into from Feb 12, 2020

Conversation

vsinghal13
Copy link
Contributor

Description

Libsonnet mixin seems to be using yq which is broken as we use the latest. Commenting out the yaml generation from CI to unblock merging PR's.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

rvmiller89
rvmiller89 approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@rvmiller89 rvmiller89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a # TODO(vijit, 2019-02-11)... comment, but otherwise LGTM

@vsinghal13 vsinghal13 merged commit 241aeb2 into master Feb 12, 2020
@vsinghal13 vsinghal13 deleted the vsinghal-disable-libsonnet-ci branch February 12, 2020 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvmiller89 rvmiller89 rvmiller89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vsinghal13 @rvmiller89