Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove cluster label from prometheus config in values.yaml #422

Merged
merged 3 commits into from Feb 18, 2020
Merged

remove cluster label from prometheus config in values.yaml #422

merged 3 commits into from Feb 18, 2020

Conversation

vsinghal13
Copy link
Contributor

Description

This PR removes cluster label from prometheus config in values.yaml and adds it in the fluentd metrics pipeline.

This will avoid the hassle of specifying the cluster name in the helm install command twice.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

samjsong
samjsong approved these changes Feb 15, 2020
View reviewed changes
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, glad to see it worked

frankreno
frankreno approved these changes Feb 17, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We will need to update docs for this change. cc @drduke1

@vsinghal13 vsinghal13 merged commit 2691230 into master Feb 18, 2020
@vsinghal13 vsinghal13 deleted the vsinghal-add-clustername-metrics-fluentd branch February 18, 2020 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankreno frankreno frankreno approved these changes

@maimaisie maimaisie maimaisie approved these changes

@samjsong samjsong samjsong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vsinghal13 @frankreno @maimaisie @samjsong