Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds the opentelemetry collector #424

Merged
merged 3 commits into from Feb 20, 2020
Merged

Adds the opentelemetry collector #424

merged 3 commits into from Feb 20, 2020

Conversation

perk-sumo
Copy link
Contributor

@perk-sumo perk-sumo commented Feb 18, 2020 •
edited

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

frankreno
frankreno approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - barring some of the comments I left.

deploy/helm/sumologic/templates/otelcol-deployment.yaml Show resolved Hide resolved
deploy/helm/sumologic/templates/otelcol-deployment.yaml Outdated Show resolved Hide resolved
deploy/kubernetes/fluentd-sumologic.yaml.tmpl Show resolved Hide resolved
deploy/helm/sumologic/values.yaml Outdated Show resolved Hide resolved
deploy/helm/sumologic/values.yaml Outdated Show resolved Hide resolved
@rvmiller89 rvmiller89 removed their request for review February 19, 2020 17:22
sumo-drosiek
sumo-drosiek approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I have some issues with sending data to collector itself, but probably only on my side

@perk-sumo perk-sumo force-pushed the add-opentelemetry-collector branch 3 times, most recently from b3476f8 to 052e7a3 Compare February 20, 2020 08:34
@perk-sumo perk-sumo merged commit 973e57e into master Feb 20, 2020
@perk-sumo perk-sumo deleted the add-opentelemetry-collector branch February 20, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankreno frankreno frankreno approved these changes

@samjsong samjsong samjsong approved these changes

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@vsinghal13 vsinghal13 Awaiting requested review from vsinghal13

@pmm-sumo pmm-sumo Awaiting requested review from pmm-sumo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@perk-sumo @frankreno @samjsong @pmm-sumo @sumo-drosiek