Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.0] Expose Fluentd config without ENV vars - take 3 #428

Merged
merged 9 commits into from Feb 26, 2020

Conversation

samjsong
Copy link
Contributor

Description

After much delay, seems we're finally ready for the major release. A lot had changed since #330 so I re-did the PR to avoid mistakes. Hopefully the commit-by-commit read is a lot cleaner this time, I learned a lot from the previous two attempts 😅

The changes detailed in #333 are still valid, namely

  1. Re-organized values.yaml for usability
  2. Remove the use of ENV vars to get rid of that layer of indirection
  3. Deprecate certain configs in the kubernetes_sumologic plugin
  4. Expose Fluentd's config to Helm users
Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

Copy link
Contributor

@vsinghal13 vsinghal13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Sam! :)

@samjsong samjsong changed the title [breaking change] Expose Fluentd config without ENV vars - take 3 [1.0.0] Expose Fluentd config without ENV vars - take 3 Feb 21, 2020
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Nice work! Will we add a migration doc in another PR?

@samjsong samjsong merged commit 50a5265 into master Feb 26, 2020
@samjsong samjsong deleted the ssong-remove-env-var branch February 26, 2020 07:52
@samjsong samjsong mentioned this pull request Mar 9, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants