Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.0] Persistence volume #429

Merged
merged 8 commits into from Feb 26, 2020
Merged

[1.0.0] Persistence volume #429

merged 8 commits into from Feb 26, 2020

Conversation

maimaisie
Copy link
Contributor

Description

Brings back changes from #351, #388 and add headless services for statefulsets.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in
  • Redeploy fluentd pods during quota is exceeded and ensure data is not lost after unthrottling the account

Copy link
Contributor

@vsinghal13 vsinghal13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you please provide more info about the usage of headless service for stateful sets?

@maimaisie
Copy link
Contributor Author

@vsinghal13 I think it's used to assign unique network identity to each pod in the statefulset because pods in statefulsets are unique and stateful, you can read more here https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#stable-network-id

Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's hold on merging for the minor release

@samjsong samjsong changed the title Persistence volume [1.0.0] Persistence volume Feb 21, 2020
@samjsong samjsong merged commit c10c66f into master Feb 26, 2020
@samjsong samjsong deleted the maisie-pv2 branch February 26, 2020 09:00
@samjsong samjsong mentioned this pull request Mar 9, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants