New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.0.0] Persistence volume #429
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could you please provide more info about the usage of headless service for stateful sets?
@vsinghal13 I think it's used to assign unique network identity to each pod in the statefulset because pods in statefulsets are unique and stateful, you can read more here https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#stable-network-id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's hold on merging for the minor release
Description
Brings back changes from #351, #388 and add headless services for statefulsets.
Testing performed