Support custom release and namespace #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsinghal13
requested review from
frankreno,
samjsong,
maimaisie and
rvmiller89
rvmiller89
reviewed
Feb 19, 2020
rvmiller89
approved these changes
Feb 19, 2020
samjsong
reviewed
Feb 19, 2020
| - name: CHART | ||
| valueFrom: | ||
| configMapKeyRef: | ||
| name: sumologic-configmap |
There was a problem hiding this comment.
Have we tested the non-helm case? What happens if the configmap has not been created yet at the time of prometheus install? Will this be able to pick up the values from the configmap later when it is created? Same for fluent-bit
There was a problem hiding this comment.
Since the configmap creation is part of the fluentd-sumologic.yaml.tmpl, it will be created as the first step as per the Non-Helm Installation docs, so it will be available by default. https://github.com/SumoLogic/sumologic-kubernetes-collection/blob/v0.14.0/deploy/docs/Non_Helm_Installation.md#deploy-fluentd
frankreno
approved these changes
Feb 20, 2020
@frankreno Yes, verified the upgrade path as well. It is working fine. |
samjsong
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes use of a new configmap to store the release name and using the k8s downward API for accessing the namespace where the pods are deployed. These two params are then exposed as env variables to fluent-bit and prometheus, to make the configuration dynamic.
Testing performed