add affinity config in fluentd deployment #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsinghal13
requested review from
rvmiller89,
frankreno,
maimaisie and
samjsong
vsinghal13
commented
Feb 21, 2020
Comment on lines
+42
to
+45
| - key: app | ||
| operator: In | ||
| values: | ||
| - prometheus-operator-prometheus |
There was a problem hiding this comment.
This section checks for the prometheus app label.
vsinghal13
commented
Feb 21, 2020
Comment on lines
+38
to
+41
| - key: app | ||
| operator: In | ||
| values: | ||
| - {{ template "sumologic.labels.app" . }} |
There was a problem hiding this comment.
This section checks for the fleuntd app label.
vsinghal13
commented
Feb 21, 2020
| operator: In | ||
| values: | ||
| - prometheus-operator-prometheus | ||
| topologyKey: "kubernetes.io/hostname" |
There was a problem hiding this comment.
The topologyKey is the label for a particular node.
frankreno
approved these changes
Feb 21, 2020
There was a problem hiding this comment.
LGTM. Adding @perk-sumo as a reviewer as he has some experience with this as well.
perk-sumo
reviewed
Feb 21, 2020
| @@ -6,7 +6,7 @@ | |||
| sumologicCollector:: { | |||
| remoteWriteConfigs+: [ | |||
| { | |||
| url: $._config.sumologicCollectorSvc + "prometheus.metrics.state", | |||
There was a problem hiding this comment.
Are those changes OK? Why they were expanded now with this PR?
There was a problem hiding this comment.
This has been fixed, by merging master into the branch.
perk-sumo
approved these changes
Feb 21, 2020
samjsong
approved these changes
Feb 21, 2020
| @@ -8,6 +8,8 @@ nameOverride: "" | |||
| deployment: | |||
| nodeSelector: {} | |||
| tolerations: {} | |||
| affinity: {} | |||
| podAntiAffinity: "soft" | |||
There was a problem hiding this comment.
can you also leave a comment here for the customers that the accepted values are "soft" and "hard", and what those mean?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR exposes the use of
podAntiAffinityto better schedule the fluentd replicas and prometheus pods across nodes.By default, we are using a
preferredDuringSchedulingIgnoredDuringExecutionconfiguration aliassoftwhich will check the conditions and schedule accordingly even if the conditions are not met.The
requiredDuringSchedulingIgnoredDuringExecutionconfiguration aliashardwill keep the pods in Pending state if any of the conditions are not met.Conditions:
Testing performed