Add more attributes extracted for traces #438
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,8 +42,8 @@ otelcolDeployment: | |
| # Memory Ballast size should be max 1/3 to 1/2 of memory. | ||
| memBallastSizeMib: "683" | ||
| image: | ||
| name: "sumologic/opentelemetry-collector" | ||
| tag: "0.0.0" | ||
|
There was a problem hiding this comment. @pmaciolek could you update? There was a problem hiding this comment. That's really good point - please use the tagged otelcol release. |
||
| pullPolicy: IfNotPresent | ||
|
|
||
| sumologic: | ||
|
|
@@ -508,3 +508,76 @@ falco: | |
| # enabled: true | ||
| falco: | ||
| jsonOutput: true | ||
|
|
||
| otelcol: | ||
| processors: | ||
| k8s_tagger: | ||
| enabled: true | ||
| passthrough: false | ||
| extract: | ||
| metadata: | ||
| # extract the following well-known metadata fields | ||
| - containerId | ||
| - containerName | ||
| - containerImage | ||
| - cluster | ||
| - daemonSetName | ||
| - deployment | ||
| - hostName | ||
| - namespace | ||
| - namespaceId | ||
| - node | ||
| - owners | ||
| - podId | ||
| - podName | ||
| - replicaSetName | ||
| - serviceName | ||
| - startTime | ||
| - statefulSetName | ||
| tags: | ||
| containerId: container_id | ||
| containerName: container_name | ||
| containerImage: conatiner_image | ||
| cluster: cluster | ||
| daemonSetName: daemonset | ||
| deployment: deployment | ||
| hostName: hostname | ||
| namespace: namespace | ||
| namespaceId: namespace_id | ||
| node: node | ||
| podId: pod_id | ||
| podName: pod | ||
| replicaSetName: replicaset | ||
| serviceName: service_name | ||
| startTime: start_time | ||
| statefulSetName: statefulset | ||
| annotations: | ||
| - tag_name: pod_annotation_%s | ||
| key: "*" | ||
| labels: | ||
| - tag_name: pod_label_%s | ||
| key: "*" | ||
| batch: | ||
| enabled: true | ||
| send_batch_size: 1024 | ||
| timeout: 5s | ||
| queued_retry: | ||
| enabled: true | ||
| num_workers: 16 | ||
| queue_size: 10000 | ||
| retry_on_failure: true | ||
| receivers: | ||
| jaeger: | ||
| enabled: true | ||
| zipkin: | ||
| enabled: true | ||
| endpoint: "0.0.0.0:9411" | ||
| opencensus: | ||
| enabled: true | ||
| extensions: | ||
| health_check: | ||
| enabled: true | ||
| exporters: | ||
| zipkin: | ||
| enabled: true | ||
| url: null | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@perk-sumo The challenge here is that there is a number of processors: https://github.com/open-telemetry/opentelemetry-collector/tree/master/processor - the list is actually growing and their properties might change over time.
An ideal solution would to provide a template with the full config file, but we are not sure how to tackle it. Do you have some suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sumo-drosiek perhaps we should minimally add sampling processors: https://github.com/open-telemetry/opentelemetry-collector/tree/master/processor#sampling-processor ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I think about it more and more, we should just take full config branch and put it as a configmap. If user have own processors it's gonna add changes to values or config file anyway. Additionally we want to support
--setflags@perk-sumo any thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not so nice proposal, but had to support dynamic value for url :D
bb9c9b0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to keep some defaults for clients who don't want to deal with the config that much.
We could do it like fluent-bit: provide sane defaults in config.yaml file with some flags in values.yaml and if someone want to have a totally different config provide a special key in values.yaml for that.
We could also provide the template config but I'm not sure if that should go to values.yaml or we should create a new file for that like values.otelcol.yaml or sth. With that client would need to copy and paste something into values.yaml by hand.
I don't like the idea of whole otelcol config inside default values.yaml because it will grow really huge and that doesn't seem right.
Please take a look at:
https://github.com/helm/charts/blob/master/stable/fluent-bit/values.yaml#L146
https://github.com/helm/charts/blob/master/stable/fluent-bit/templates/config.yaml#L1
It's similar to what @sumo-drosiek did.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could do it like fluent-bitI think that our case differs. We are able to useyaml. fluentbit were obligated to convert yaml configuration into fluent-bit specific format.I would like to stick to the
values.yaml. It's more clear and in both casesvalues.yamlwill be growing