Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0.0] add fluentd to name of both logs and events fluentd statefulsets #454

Merged
merged 5 commits into from
Mar 25, 2020
Merged

[1.0.0] add fluentd to name of both logs and events fluentd statefulsets #454

merged 5 commits into from
Mar 25, 2020

Conversation

vsinghal13
Copy link
Contributor

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

perk-sumo
perk-sumo approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@Gourav2906
Copy link
Contributor

Please check health check dashboard in Kubernetes App still works

samjsong
samjsong reviewed Mar 4, 2020
View reviewed changes
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to update service names and others for consistency?

@samjsong samjsong changed the title add fluentd to name of both logs and events fluentd statefulsets [1.0.0] add fluentd to name of both logs and events fluentd statefulsets Mar 4, 2020
@samjsong
Copy link
Contributor

samjsong commented Mar 4, 2020

let's also hold on merging since this is a breaking change.

@perk-sumo perk-sumo added this to the v1.0 milestone Mar 5, 2020
@vsinghal13 vsinghal13 merged commit 9038f69 into master Mar 25, 2020
@vsinghal13 vsinghal13 deleted the vsinghal-change-fluentd-statefulset-name branch March 25, 2020 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samjsong samjsong samjsong approved these changes

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@perk-sumo perk-sumo perk-sumo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vsinghal13 @Gourav2906 @samjsong @sumo-drosiek @perk-sumo