-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
downgrade falco helm chart to 1.1.0 #457
Conversation
Is this recommended with Helm, or is it better practice to use the image provided in the Helm chart (whose subchart dependency is already pinned in |
This is done as a work-around for now to get the precompiled kernel modules. We would have downgrade the falco helm chart version to get this particular app version and then upgrade it again later on. With this change, we can override the image tag and still keep the helm chart version intact. |
Not opposed to this, but why not downgrade the helm chart version then? |
That is an excellent point by @rvmiller89 - I think we should just downgrade the whole falco chart to |
@rvmiller89 @perk-sumo Thanks for the inputs. Modified it to use the older helm chart version. |
@@ -8,7 +8,7 @@ dependencies: | |||
repository: https://kubernetes-charts.storage.googleapis.com/ | |||
condition: prometheus-operator.enabled | |||
- name: falco | |||
version: 1.1.1 | |||
version: 1.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should also update the dependency table in master branch so it gets included when we cut the next release?
…oLogic/sumologic-kubernetes-collection into vsinghal-pin-falco-image-tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend updating the PR title and description to avoid confusion in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR downgrade falco helm chart to 1.1.0 which points to falco image tag
0.18.0
for resolving the precompiled kernel modules error.Testing performed