Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent fluentd from handling records containing its own logs. #460

Merged
merged 2 commits into from Mar 4, 2020

Conversation

vsinghal13
Copy link
Contributor

Description

We do not want to ingest the demo log which we use for fluentd liveness probe to be ingested in Sumo. This PR prevents fluentd from handling records containing its own logs.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these the new "health check" logs we've been seeing? LGTM

@rvmiller89
Copy link
Contributor

This won't prevent us from ingesting the dropped chunk message?

@perk-sumo
Copy link
Contributor

If we drop all the fluentd logs altogether we won't be able to troubleshoot fluentd problems.
Maybe it's better to drop only the liveness health check logs?

@perk-sumo
Copy link
Contributor

My suggestion is: filter liveness logs out and add some throttling for the fluentd logs, there is a plugin for that: https://github.com/rubrikinc/fluent-plugin-throttle

@vsinghal13
Copy link
Contributor Author

Are these the new "health check" logs we've been seeing? LGTM

Yes, these are the ones sent via the liveness probe.

@vsinghal13
Copy link
Contributor Author

If we drop all the fluentd logs altogether we won't be able to troubleshoot fluentd problems.
Maybe it's better to drop only the liveness health check logs?

The fluentd logs for troubleshooting will also be written with container tags.

@vsinghal13 vsinghal13 closed this Mar 3, 2020
@vsinghal13 vsinghal13 reopened this Mar 3, 2020
@vsinghal13 vsinghal13 merged commit 34118cc into master Mar 4, 2020
@vsinghal13 vsinghal13 deleted the vsinghal-filter-fluentd-health-check-logs branch March 4, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants