Expose setting resource constraints for helm dependencies #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed and reopened to trigger the Travis CI again. |
samjsong
reviewed
Mar 5, 2020
| @@ -337,6 +337,15 @@ metrics-server: | |||
| ## Configure fluent-bit | |||
| ## ref: https://github.com/helm/charts/blob/master/stable/fluent-bit/values.yaml | |||
| fluent-bit: | |||
| ## Resource limits for fluent-bit | |||
| resources: {} | |||
There was a problem hiding this comment.
I believe prometheus operator does not have default resource limits defined, can we confirm whether fluent-bit has any default resource limits? otherwise this would be overriding the defined defaults
There was a problem hiding this comment.
There are no default limits for 2.8.1 version: https://github.com/helm/charts/blob/866c1da688dc13d176a9b251ff4636a162c6a735/stable/fluent-bit/values.yaml#L187
samjsong
approved these changes
Mar 6, 2020
perk-sumo
force-pushed
the
vsinghal-expose-resource-for-helm-dependencies
branch
from
04db3ad
to
3b5d8f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR exposes setting resource constraints for fluentbit, prometheus, prometheus-operator.
Testing performed