Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0.0] filter metrics #466

Merged
merged 4 commits into from
Mar 24, 2020
Merged

[1.0.0] filter metrics #466

merged 4 commits into from
Mar 24, 2020

Conversation

vsinghal13
Copy link
Contributor

Description

This PR removes the metrics that are not used by Sumo apps/dashboards.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@vsinghal13
Copy link
Contributor Author

Closed and reopened to trigger the Travis CI again.

@vsinghal13 vsinghal13 closed this Mar 5, 2020
@vsinghal13 vsinghal13 reopened this Mar 5, 2020
@samjsong samjsong changed the title filter metrics [1.0.0] filter metrics Mar 5, 2020
@samjsong samjsong added this to the v1.0 milestone Mar 5, 2020
@samjsong
Copy link
Contributor

samjsong commented Mar 5, 2020

LGTM but as discussed earlier this is a breaking change so we will include it with 1.0.0

perk-sumo
perk-sumo approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsinghal13 vsinghal13 merged commit 562a139 into master Mar 24, 2020
@vsinghal13 vsinghal13 deleted the vsinghal-filter-metrics branch March 24, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perk-sumo perk-sumo perk-sumo approved these changes

@samjsong samjsong Awaiting requested review from samjsong

@rvmiller89 rvmiller89 Awaiting requested review from rvmiller89

@maimaisie maimaisie Awaiting requested review from maimaisie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vsinghal13 @samjsong @perk-sumo