Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify params in values.yaml #472

Merged
merged 2 commits into from Mar 6, 2020
Merged

Clarify params in values.yaml #472

merged 2 commits into from Mar 6, 2020

Conversation

vsinghal13
Copy link
Contributor

Description

Clarify params in values.yaml for better understanding and usability.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

samjsong
samjsong approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for adding these

@samjsong samjsong added this to the v0.16 milestone Mar 6, 2020
@vsinghal13 vsinghal13 merged commit 3cdc6ac into master Mar 6, 2020
@vsinghal13 vsinghal13 deleted the vsinghal-add-comments-values-yaml branch March 6, 2020 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samjsong samjsong samjsong approved these changes

@perk-sumo perk-sumo Awaiting requested review from perk-sumo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.16
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vsinghal13 @samjsong