Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for alpha and beta builds on Travis #478

Merged
merged 1 commit into from Mar 10, 2020
Merged

Allow for alpha and beta builds on Travis #478

merged 1 commit into from Mar 10, 2020

Conversation

perk-sumo
Copy link
Contributor

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

sumo-drosiek
sumo-drosiek reviewed Mar 10, 2020
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't alpha and beta be together in one regex?

@perk-sumo perk-sumo force-pushed the ci-allow-alpha-and-beta-builds branch from 8918ab5 to 3dfebb5 Compare March 10, 2020 11:04
pmm-sumo
pmm-sumo approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@pmm-sumo pmm-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perk-sumo perk-sumo force-pushed the ci-allow-alpha-and-beta-builds branch from 3dfebb5 to be4a839 Compare March 10, 2020 11:43
@perk-sumo perk-sumo merged commit be4a839 into master Mar 10, 2020
@perk-sumo perk-sumo deleted the ci-allow-alpha-and-beta-builds branch March 10, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmm-sumo pmm-sumo pmm-sumo approved these changes

@samjsong samjsong Awaiting requested review from samjsong

@vsinghal13 vsinghal13 Awaiting requested review from vsinghal13

@sumo-drosiek sumo-drosiek Awaiting requested review from sumo-drosiek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@perk-sumo @pmm-sumo @sumo-drosiek