Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing source_category_replace_dash to systemd conf. #483

Merged
merged 1 commit into from Mar 16, 2020
Merged

Add missing source_category_replace_dash to systemd conf. #483

merged 1 commit into from Mar 16, 2020

Conversation

bboerst
Copy link
Contributor

@bboerst bboerst commented Mar 10, 2020 •
edited

Description

This PR adds source_category_replace_dash to systemd log filters.
The default setting is "/" and we noticed that container logs were honoring our override, but systemd logs were not.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@bboerst bboerst mentioned this pull request Mar 10, 2020
Closed
@bboerst
Copy link
Contributor Author

bboerst commented Mar 10, 2020

Ref: #484

vsinghal13
vsinghal13 approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@vsinghal13 vsinghal13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perk-sumo perk-sumo added this to the v0.17 milestone Mar 11, 2020
perk-sumo
perk-sumo approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

sumo-drosiek
sumo-drosiek approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samjsong
samjsong approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we'll have to keep this in mind when we make the 1.0.0 change

@perk-sumo perk-sumo merged commit 908b664 into SumoLogic:master Mar 16, 2020
@samjsong samjsong mentioned this pull request Mar 16, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samjsong samjsong samjsong approved these changes

@vsinghal13 vsinghal13 vsinghal13 approved these changes

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@perk-sumo perk-sumo perk-sumo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.17
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bboerst @samjsong @vsinghal13 @sumo-drosiek @perk-sumo