New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Remove some non-tracing changes from v0.16 - merge them later… #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some previous comments see:
(apparently github links to the commit without PR context so I need to put a raw link) |
perk-sumo
commented
Mar 13, 2020
perk-sumo
force-pushed
the
bring-back-v017-changes
branch
6 times, most recently
from
March 13, 2020 16:58
d10fd54
to
a8ae719
Compare
vsinghal13
reviewed
Mar 13, 2020
samjsong
reviewed
Mar 13, 2020
perk-sumo
force-pushed
the
bring-back-v017-changes
branch
3 times, most recently
from
March 13, 2020 19:29
767c93b
to
4f4e5cf
Compare
… on as v0.17" This reverts commit 4433281.
perk-sumo
force-pushed
the
bring-back-v017-changes
branch
from
March 13, 2020 19:30
4f4e5cf
to
e0c1365
Compare
vsinghal13
approved these changes
Mar 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @perk-sumo !!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… on as v0.17"
This reverts commit 4433281.
Description
Testing performed