Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove some non-tracing changes from v0.16 - merge them later… #494

Merged
merged 3 commits into from Mar 13, 2020

Conversation

perk-sumo
Copy link
Contributor

@perk-sumo perk-sumo commented Mar 13, 2020

… on as v0.17"

This reverts commit 4433281.

Description
  1. Falco helm chart change
  2. Removing fluentd health check logs
  3. Resource config for helm chart dependencies
Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@perk-sumo perk-sumo added this to the v0.17 milestone Mar 13, 2020
@perk-sumo
Copy link
Contributor Author

perk-sumo commented Mar 13, 2020

For some previous comments see:

https://github.com/SumoLogic/sumologic-kubernetes-collection/pull/473/commits/4433281c889f13797d4205c9cf817029194ec64c

(apparently github links to the commit without PR context so I need to put a raw link)

deploy/README.md Outdated Show resolved Hide resolved
@perk-sumo perk-sumo force-pushed the bring-back-v017-changes branch 6 times, most recently from d10fd54 to a8ae719 Compare March 13, 2020 16:58
deploy/README.md Outdated Show resolved Hide resolved
@perk-sumo perk-sumo force-pushed the bring-back-v017-changes branch 3 times, most recently from 767c93b to 4f4e5cf Compare March 13, 2020 19:29
Copy link
Contributor

@vsinghal13 vsinghal13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @perk-sumo !!

@perk-sumo perk-sumo merged commit f3c3572 into master Mar 13, 2020
@perk-sumo perk-sumo deleted the bring-back-v017-changes branch March 13, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants