Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helm RBAC error and solution #527

Merged
merged 3 commits into from Mar 27, 2020
Merged

Add helm RBAC error and solution #527

merged 3 commits into from Mar 27, 2020

Conversation

spchin
Copy link
Contributor

@spchin spchin commented Mar 25, 2020

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@vsinghal13 vsinghal13 requested review from drduke1, vsinghal13, perk-sumo and samjsong and removed request for drduke1 March 25, 2020 19:55
vsinghal13
vsinghal13 requested changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@vsinghal13 vsinghal13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except the yaml formatting.

deploy/docs/Troubleshoot_Collection.md Outdated
kubectl -n kube-system delete service/tiller-deploy
```
2. Create a file called rbac-config.yaml with the following content
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spchin This should be ```yaml to maintain the exact format as in the yaml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drduke1 could you please confirm the same ?

@perk-sumo perk-sumo added this to the v1.0 milestone Mar 26, 2020
@vsinghal13 vsinghal13 self-requested a review March 26, 2020 17:12
@vsinghal13 vsinghal13 closed this Mar 26, 2020
@vsinghal13 vsinghal13 reopened this Mar 26, 2020
@vsinghal13 vsinghal13 closed this Mar 27, 2020
@vsinghal13 vsinghal13 reopened this Mar 27, 2020
@vsinghal13 vsinghal13 merged commit e8a76d4 into SumoLogic:master Mar 27, 2020
vsinghal13 pushed a commit that referenced this pull request Mar 30, 2020
@spchin @samjsong @vsinghal13
Add helm RBAC error and solution (#527)
7fd58bd 
* Add helm RBAC error and solution

* use yaml in code block

* fix whitespace

Co-authored-by: Sam Song <ssong@sumologic.com>
vsinghal13 pushed a commit that referenced this pull request Mar 31, 2020
@spchin @samjsong @vsinghal13
Add helm RBAC error and solution (#527)
66d438d 
* Add helm RBAC error and solution

* use yaml in code block

* fix whitespace

Co-authored-by: Sam Song <ssong@sumologic.com>
vsinghal13 pushed a commit that referenced this pull request Mar 31, 2020
@spchin @samjsong @vsinghal13
Add helm RBAC error and solution (#527)
9f39f2f 
* Add helm RBAC error and solution

* use yaml in code block

* fix whitespace

Co-authored-by: Sam Song <ssong@sumologic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drduke1 drduke1 drduke1 approved these changes

@vsinghal13 vsinghal13 vsinghal13 approved these changes

@perk-sumo perk-sumo Awaiting requested review from perk-sumo

@samjsong samjsong Awaiting requested review from samjsong

Assignees
No one assigned
Labels
backport-documentation
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@spchin @drduke1 @vsinghal13 @perk-sumo @samjsong