Control plane metrics #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
changed the title
|
I skip etcd in this PR because I'm not really sure which metrics do we expect. We already send some |
|
I recommend unified view for this PR (because of helm templates 😢 ) |
sumo-drosiek
changed the title
samjsong
approved these changes
Apr 8, 2020
sumo-drosiek
force-pushed
the
drosiek-control-plane-metrics
branch
from
c3080f2
to
4a4b12f
Compare
Fix according to misunderstanding of writeRelabelConfigs prometheus/prometheus#3996
vsinghal13
approved these changes
Apr 9, 2020
We can limit scope using additional conditions if the list of exact names will be known
sumo-drosiek
force-pushed
the
drosiek-control-plane-metrics
branch
from
b4644ef
to
a066e0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add control plane metrics:
Also extract match section from the metrics configuration to the helm template function
Testing performed