Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HPA for fluentd after changing it into statefulset #576

Merged
merged 1 commit into from Apr 8, 2020
Merged

Fix HPA for fluentd after changing it into statefulset #576

merged 1 commit into from Apr 8, 2020

Conversation

perk-sumo
Copy link
Contributor

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@perk-sumo perk-sumo added this to the v1.0 milestone Apr 8, 2020
vsinghal13
vsinghal13 approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@vsinghal13 vsinghal13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @perk-sumo ! Thanks

@perk-sumo perk-sumo merged commit 7bc4372 into master Apr 8, 2020
@perk-sumo perk-sumo deleted the fix-fluentd-hpa branch April 8, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsinghal13 vsinghal13 vsinghal13 approved these changes

@samjsong samjsong Awaiting requested review from samjsong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@perk-sumo @vsinghal13