Add note on how to handle Prometheus replicas. #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankreno
requested review from
drduke1,
samjsong,
vsinghal13 and
MariePMcGarry
and removed request for
drduke1
deploy/docs/existingPrometheusDoc.md
Outdated
| @@ -1,5 +1,7 @@ | |||
| # How to install if you have an existing Prometheus operator | |||
|
|
|||
| __NOTE__: The Sumo Logic Kubernetes collection process does not support collecting metrics from when scaling Prometheus replicas. If you are running multiple Prometheus replicas, please follow our [Side-by-Side](SideBySidePrometheus.md) instructions. | |||
There was a problem hiding this comment.
I suspect missing or extra word here: "metrics from when"
There was a problem hiding this comment.
good catch, fixed.
deploy/docs/standAlonePrometheus.md
Outdated
| @@ -1,5 +1,7 @@ | |||
| # How to install if you have standalone Prometheus | |||
|
|
|||
| __NOTE__: The Sumo Logic Kubernetes collection process does not support collecting metrics from when scaling Prometheus replicas. If you are running multiple Prometheus replicas, please follow our [Side-by-Side](SideBySidePrometheus.md) instructions. | |||
There was a problem hiding this comment.
I suspect missing or extra word here: "metrics from when"
There was a problem hiding this comment.
good catch, fixed.
samjsong
approved these changes
Apr 22, 2020
vsinghal13
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update docs with a note on support and handling for multiple Prometheus replicas.
Testing performed