Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose fluentd output section for logs #585

Merged
merged 4 commits into from
Apr 22, 2020

Conversation

vsinghal13
Copy link
Contributor

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@vsinghal13 vsinghal13 requested review from frankreno, samjsong, perk-sumo and sumo-drosiek and removed request for frankreno April 22, 2020 04:54
overrideRawConfig: |-

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please strip spaces

Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except one nit

Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one thing though, to be consistent we should expose the default output as well...

Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsinghal13 vsinghal13 closed this Apr 22, 2020
@vsinghal13 vsinghal13 reopened this Apr 22, 2020
@perk-sumo perk-sumo added this to the v1.0 milestone Apr 22, 2020
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@perk-sumo perk-sumo closed this Apr 22, 2020
@perk-sumo perk-sumo reopened this Apr 22, 2020
@vsinghal13
Copy link
Contributor Author

@perk-sumo The PR seems to be stuck?

@perk-sumo perk-sumo force-pushed the vsinghal-expose-output-fluentd branch from e139aa0 to 7b372cd Compare April 22, 2020 16:58
@perk-sumo perk-sumo merged commit dd099cf into master Apr 22, 2020
@perk-sumo perk-sumo deleted the vsinghal-expose-output-fluentd branch April 22, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants