Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filtering metrics for old kubernetes versions #586

Merged
merged 1 commit into from Apr 22, 2020
Merged

Fix filtering metrics for old kubernetes versions #586

merged 1 commit into from Apr 22, 2020

Conversation

sumo-drosiek
Copy link
Contributor

Description

Cast version which have suffixes to the base one before comparison: e.g. 15+ -> 15

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@sumo-drosiek
Copy link
Contributor Author

It's good candidate for function, but there are only two occurrences so I changed it in place.

@sumo-drosiek sumo-drosiek added this to the v1.0 milestone Apr 22, 2020
vsinghal13
vsinghal13 approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@vsinghal13 vsinghal13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

frankreno
frankreno approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

perk-sumo
perk-sumo approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@perk-sumo perk-sumo merged commit 697e9c8 into master Apr 22, 2020
@perk-sumo perk-sumo deleted the drosiek-fix-old-metrics-filter branch April 22, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankreno frankreno frankreno approved these changes

@samjsong samjsong samjsong approved these changes

@vsinghal13 vsinghal13 vsinghal13 approved these changes

@perk-sumo perk-sumo perk-sumo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sumo-drosiek @frankreno @samjsong @vsinghal13 @perk-sumo