Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split logs + metrics Fluentd sts #588

Merged
merged 5 commits into from
Apr 30, 2020
Merged

Conversation

samjsong
Copy link
Contributor

@samjsong samjsong commented Apr 22, 2020

Description

Splitting Logs and Metrics Fluentd statefulsets for scalability

Also noticed that we had not updated the service monitors for Prometheus in values.yaml, updated those to include the fluentd name

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we planning to do some breaking changes in the future (especially configuration separation)?

I feel that we should refactor some configuration logic, but on the other hand that change is crucial as part of 1.0.0 which is already in pre-release phase

Copy link
Contributor

@vsinghal13 vsinghal13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except few changes

Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samjsong this is great, thank you! :)
One thing is we need to work out the details before it can be merged.

deploy/helm/sumologic/values.yaml Outdated Show resolved Hide resolved
@perk-sumo perk-sumo added this to the v1.0 milestone Apr 24, 2020
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with other feedback and left a few minor comments. Also, we will need to make sure doc changes for any debugging depending on name are updated.

deploy/helm/prometheus-overrides.yaml Outdated Show resolved Hide resolved
@samjsong
Copy link
Contributor Author

Hi team! I've made the requested changes:

  1. move the relevant new configs for metrics under the fluentd.metrics key, as well as moving the parallel configs for logs under the fluentd.logs key
  2. add -logs suffix to the logs fluentd name. (However I've left the tracing config in the logs fluentd so the name is a little misleading)

@samjsong
Copy link
Contributor Author

@sumo-drosiek the CI seems to have failed due to something with the kubernetes-tools change, would you mind taking a look if you get the chance? thank you! :)

@perk-sumo perk-sumo force-pushed the ssong-split-logs-metrics-fluentd branch from 17b0f15 to 433db56 Compare April 29, 2020 07:27
@perk-sumo
Copy link
Contributor

@samjsong I've rebased your branch on master so that building tools won't break the build.
Also I like the changes you've made, thank you! 👏

Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems to be working :)

@perk-sumo perk-sumo force-pushed the ssong-split-logs-metrics-fluentd branch from 4e24247 to c3ed6a0 Compare April 30, 2020 06:47
@perk-sumo perk-sumo merged commit 4d21605 into master Apr 30, 2020
@perk-sumo perk-sumo deleted the ssong-split-logs-metrics-fluentd branch April 30, 2020 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants