Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose resource config for prometheus node-exporter and kube state metrics. #593

Merged
merged 2 commits into from Apr 24, 2020
Merged

Expose resource config for prometheus node-exporter and kube state metrics. #593

merged 2 commits into from Apr 24, 2020

Conversation

vsinghal13
Copy link
Contributor

Expose resource config for prometheus node-exporter and kube state metrics.

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@vsinghal13
Update values.yaml
df75f75 
Expose resource config for prometheus node-exporter and kube state metrics.
@vsinghal13 vsinghal13 closed this Apr 24, 2020
@vsinghal13 vsinghal13 reopened this Apr 24, 2020
samjsong
samjsong approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming we have confirmed that there weren't any defaults already set for these in the prometheus chart

frankreno
frankreno approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming these are the respective defaults form the sub-chart.

@vsinghal13 vsinghal13 merged commit d43aef0 into master Apr 24, 2020
@vsinghal13 vsinghal13 deleted the vsinghal13-patch-1 branch April 24, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankreno frankreno frankreno approved these changes

@samjsong samjsong samjsong approved these changes

@sumo-drosiek sumo-drosiek Awaiting requested review from sumo-drosiek

@perk-sumo perk-sumo Awaiting requested review from perk-sumo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vsinghal13 @frankreno @samjsong