Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis Integration #61

Merged
merged 4 commits into from Jul 4, 2019
Merged

Fix Travis Integration #61

merged 4 commits into from Jul 4, 2019

Conversation

samjsong
Copy link
Contributor

@samjsong samjsong commented Jul 2, 2019

:= does assignment, and :- does not. So later in the build script when we were checking TRAVIS_TAG, since it was defined earlier it wasn't skipping the push.

See https://github.com/SumoLogic/fluentd-kubernetes-sumologic/blob/master/ci/build.sh

@samjsong samjsong changed the title only push to docker on master branch only push to docker on new tag version Jul 2, 2019
@samjsong samjsong changed the title only push to docker on new tag version Fix Travis Integration Jul 3, 2019
Copy link
Contributor

@maimaisie maimaisie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@samjsong samjsong merged commit 60cf00e into master Jul 4, 2019
@samjsong samjsong deleted the ssong-travis branch July 4, 2019 20:58
psaia pushed a commit to psaia/sumologic-kubernetes-collection that referenced this pull request May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants