Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-cast to string for particular keys #635

Merged
merged 4 commits into from
May 18, 2020
Merged

Conversation

sumo-drosiek
Copy link
Contributor

Description

Re-cast to string for particular keys

Solves #633 #634

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, LGTM!

@sumo-drosiek sumo-drosiek merged commit 3dd22e4 into master May 18, 2020
@sumo-drosiek sumo-drosiek deleted the drosiek-fix-upgrade-types branch May 18, 2020 15:18
@sumo-drosiek sumo-drosiek added this to the v1.0 milestone May 18, 2020
@sumo-drosiek sumo-drosiek added the bug Something isn't working label May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants