Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --force flag for pv #649

Merged
merged 2 commits into from May 19, 2020
Merged

Add --force flag for pv #649

merged 2 commits into from May 19, 2020

Conversation

vsinghal13
Copy link
Contributor

Add --force flag for pv

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

Add --force flag for pv
@vsinghal13 vsinghal13 changed the title Update values.yaml Update values.yaml - Add --force flag for pv May 19, 2020
@vsinghal13 vsinghal13 changed the title Update values.yaml - Add --force flag for pv Add --force flag for pv May 19, 2020
@vsinghal13 vsinghal13 added this to the v1.0 milestone May 19, 2020
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If it was true in 0.17 and they upgrade to 1.0 is it also needed?

@vsinghal13
Copy link
Contributor Author

LGTM. If it was true in 0.17 and they upgrade to 1.0 is it also needed?

Actually, PV support is not available in 0.17

@vsinghal13 vsinghal13 merged commit e0a492f into master May 19, 2020
@vsinghal13 vsinghal13 deleted the vsinghal13-force-flag-pv branch May 19, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants