Use fluentd helper function #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuting-liu
approved these changes
Jul 9, 2019
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
…Logic#65) * Add a few collectors and sources * Remove extra quotes * Change bool strings to bools * Add a few more sources * Revert "Change bool strings to bools" This reverts commit f09b7d6e8e4888daec74686f9ce1ac8fe0c06684. * Test tf plan * Remove dummy file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is found that having the
whileloop in the main thread blocks fluentd from running multiple input sources simultaneously. @samjsong found thetimer_executehelper function fromtimerhelper being used in the tail input source, which works with multiple tail sources.The
whileloops in events and service monitor are replaced bytimer_execute. The sleep for the timer is determined by the sleep used in thewhileloops before (which is different from how often watcher recreates)